fix(source-typeform) Record selector for nested streams & formatting #54690
Conversation
…tehq/airbyte into btkcodedev/typeformMigrate
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
|
While troubleshooting this, I discovered the formatting was off on the manifest. The url_path wasn't being parsed correctly. For example, we were hitting "url": "https://api.typeform.com/?page_size=200" instead of https://api.typeform.com/forms?page_size=200 for the forms stream. The other streams were like this as well. Due to this, the API was responding with HTML from the typeform home page, which is why no records were being read. The updated format should read records for all the streams! |
|
Regression looks good : https://storage.cloud.google.com/airbyte-ci-reports-multi/airbyte-ci/connectors/test/manual/btkcodedev_typeformmigrate/1740617107/9c04b4ff9d9f9d92030d089a03fa9c921b1083ac/source-typeform/1.4.1/output.html Also tested on our dev account via cloud and all looks good there too. Log: |
|
/approve-regression-tests
|
agarctfi
changed the title
What
OC issue: https://github.com/airbytehq/oncall/issues/7508
webhooks
themes
workspaces
responses
forms
are not emitting records due to having nested responses
the images stream is emitting records since this is the only stream that returns an array at the top level of the response
How
Add '*' to select all records in the nested stream
Review guide
User Impact
Can this PR be safely reverted and rolled back?