Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to Master #93

Merged
merged 62 commits into from
Apr 24, 2024
Merged

Develop to Master #93

merged 62 commits into from
Apr 24, 2024

Conversation

nick-4711
Copy link
Collaborator

Can we merge develop to master? I would like to test the OTA update by creating tags in the master branch and then build some OTA versions on these tags and see if it all works.

pnt325 and others added 30 commits March 29, 2024 19:32
@nick-4711
Copy link
Collaborator Author

I just realize that the build doesn't pass because of a small issue, see below, I will fix this

/home/runner/work/arduino/arduino/examples/OneOpenAir/OtaHandler.h: In member function 'void OtaHandler::updateFirmwareIfOutdated(String)':
/home/runner/work/arduino/arduino/examples/OneOpenAir/OtaHandler.h:20:16: error: 'GIT_VERSION' was not declared in this scope
url += GIT_VERSION;
^~~~~~~~~~~
/home/runner/work/arduino/arduino/examples/OneOpenAir/OtaHandler.h:20:16: note: suggested alternative: 'ESP_IDF_VERSION'
url += GIT_VERSION;
^~~~~~~~~~~
ESP_IDF_VERSION

@pnt325 pnt325 merged commit 26546a6 into master Apr 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants