Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell and Repertoire definition #361

Closed
sharikrish opened this issue Mar 24, 2020 · 9 comments · Fixed by #748
Closed

Cell and Repertoire definition #361

sharikrish opened this issue Mar 24, 2020 · 9 comments · Fixed by #748
Assignees
Milestone

Comments

@sharikrish
Copy link
Contributor

In our previous discussion on cell object specification (issue : #320 ) and repertoire definition described here represents "actual" Repertoire and "virtual" Repertoire

Actual repertoires being the ones that contain each cell object only once and virtual repertoire can contain them multiple times (either copied or linked).

From the previous call on MiniStd, there is a consensus that overlapping populations/repertoires need to be addressed and that two tiers of Repertoire objects could be a possible solution.

Any thoughts how we represent them in the schema?

@scharch
Copy link
Contributor

scharch commented Mar 24, 2020

Can we just add a boolean virtual field? Or maybe better would be list of linked_repertoires which would by its presence define a Repertoire as virtual

@javh
Copy link
Contributor

javh commented Mar 26, 2020

I'm having trouble understanding the distinction. A Repertoire is an arbitrary collection of records, with the scope defined by whoever decided to label the collection as a Repertoire.

What's the difference between an "actual" and "virtual" arbitrary collection? And what is the problem we want to solve? If it's data compression, by collapsing multiple Cell records into a single consensus Cell record, then it may just be a matter of allowing repertoire_id and/or sample_id to be an array.

@lgcowell
Copy link

lgcowell commented Mar 26, 2020 via email

@sharikrish
Copy link
Contributor Author

Can we just add a boolean virtual field? Or maybe better would be list of linked_repertoires which would by its presence define a Repertoire as virtual

Adding the 'virtual' flag makes sense and should be possible to implement. How to handle the meta-data associated with the linked repertoires?

@scharch
Copy link
Contributor

scharch commented Mar 26, 2020

How to handle the meta-data associated with the linked repertoires?

The point of having a linked_repertoires field would be to get the metadata from the originals without needing to copy it. I haven't completely thought it through yet, though.

@bcorrie
Copy link
Contributor

bcorrie commented Feb 8, 2024

Not sure whether this is still a v2.0 task, @scharch ? This kind of feels like a RepertoireGroup type of issue - so maybe have this land wherever RepertoireGroup lands? See #578

@scharch
Copy link
Contributor

scharch commented Feb 8, 2024

Yes, I think this would ideally be solved by RepertoireGroup...

@bussec
Copy link
Member

bussec commented Feb 11, 2024

Re-reading this thread and parts of #320, I also think that RepertoireGroup is likely the second level we are looking for. We should save the previously mentioned use case, but otherwise we can IMO close this.

@bcorrie
Copy link
Contributor

bcorrie commented Feb 11, 2024

I have create a Repertoire Group pull request (#748) and associated this issue with the pull request. So when we are comfortable the Repertoire Group addresses this we can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants