Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Decouple the benchmark runner from viewer #1411

Open
ev-br opened this issue Jun 21, 2024 · 2 comments
Open

ENH: Decouple the benchmark runner from viewer #1411

ev-br opened this issue Jun 21, 2024 · 2 comments

Comments

@ev-br
Copy link

ev-br commented Jun 21, 2024

Consider a use case: I've a test suite which uses, say, pytest-benchmark and I'd like to be able to reuse asv publish to web display.

A first step could be to document the data format asv expects. This includes json file names, formats and locations. (also #1410 ). Then writing an adapter from whatever json pytest-benchmark or other test runner produces would be easier.

@HaoZeke
Copy link
Member

HaoZeke commented Jul 1, 2024

IMO this is probably a better use case for a a plugin like the memray-plugin where say, instead of using pytest-benchmark directly and trying to match results, the benchmarks would be written using asv calling pytest-benchmark and then plugging seamlessly into the web display.

@HaoZeke HaoZeke changed the title Decouple the benchmark runner from viewer ENH: Decouple the benchmark runner from viewer Jul 1, 2024
@ev-br
Copy link
Author

ev-br commented Jul 1, 2024

Such plugin would be interesting indeed. Got to admit I've no idea how to implement one though, FWIW.

That said, I'd argue going the plugin route adds tighter coupling between different thing ASV insists on doing itself: managing the repository, managing the environments, running benchmarks and visualizing them, instead of making it looser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants