Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Restrict Redis version to <7.4 #277

Open
1 task done
timlrx opened this issue Mar 28, 2024 · 5 comments
Open
1 task done

[FEATURE] Restrict Redis version to <7.4 #277

timlrx opened this issue Mar 28, 2024 · 5 comments
Assignees
Labels
feature Should build this needs-triage Issues need triages by maintainer

Comments

@timlrx
Copy link
Collaborator

timlrx commented Mar 28, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

Heads up that Redis is also moving to a restrictive proprietary license starting from v7.4 onwards.

Suggest to restrict the version to <7.4

Is your feature request related to a problem/limitation?

Licensing issue which limits adoption and use of the software

Describe the solution you'd like

Given the dependencies to redis and the use of the subscription feature, my recommendation would be to just restrict the version for the time being.

Alternatives

Replace with an open-source Redis alternative that supports subscription.

Additional Context

No response

Related Issues/PRs

#276

@timlrx timlrx added feature Should build this needs-triage Issues need triages by maintainer labels Mar 28, 2024
@imda-benedictlee
Copy link
Contributor

Hi @timlrx, thanks for flagging this to our attention. Let me bring to the attention of the team for further discussion on where to take this.

@imda-benedictlee
Copy link
Contributor

@HanFai-IMDA for your attention.

@timlrx
Copy link
Collaborator Author

timlrx commented Jul 30, 2024

Thanks @imda-benedictlee and @HanFai-IMDA! Another possibility is to use https://github.com/valkey-io/valkey which is the linux foundation fork of redis that seems to be getting the most traction. It has more contributors and recent activity compared to redis - https://github.com/valkey-io/valkey/pulse/monthly vs https://github.com/redis/redis/pulse/monthly

@imda-benedictlee
Copy link
Contributor

Hi @timlrx, thanks for the suggestion. I think at the moment, we could go with the first suggestion to fix the version below 7.4. Will bring up the alternatives to a discussion with the team.

@HanFai-IMDA
Copy link

Noted on the change in Redis license from v7.4 onwards. Currently AI Verify install Redis server version 6.2 in the docker compose and k8s scripts. We will lock it at version 6.x until the release of AI Verify 2.0. As for the Redis clients used by the python and nodejs modules, they are licensed under MIT and not affected by Redis change in licensing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Should build this needs-triage Issues need triages by maintainer
Projects
None yet
Development

No branches or pull requests

3 participants