New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some 2xx codes considered error responses #35

Open

mithodin opened this issue Jun 2, 2022 · 0 comments · May be fixed by #36

mithodin commented Jun 2, 2022

OpErrorType consider only 200 and 201 as "successful" responses (see

openapi-typescript-fetch/src/types.ts

Line 67 in 2e0d66e

type _OpErrorType<T> = {

), when according to the HTTP spec, all 2xx status codes signify success. This becomes a problem e.g. for a DELETE request, where a success usually returns status 204 (e.g. https://github.com/OAI/OpenAPI-Specification/blob/main/examples/v3.0/petstore-expanded.json#L158)

mithodin changed the title ~~2xx codes considered error responses~~ some 2xx codes considered error responses

gentarooka linked a pull request

that will close this issue

Fix OpReturnType to support 202 status code #36

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment