Automate Generation of d.ts for Ace Editor Modes (#5518)

* add automatic modes declaration generator * fix: wrong export in ruby mode * re-generate ace-modes * ci check --------- Co-authored-by: nightwing <[email protected]>
ajaxorg · Apr 5, 2024 · e59ae67 · e59ae67
1 parent bb8256d
commit e59ae67
Show file tree

Hide file tree

Showing 5 changed files with 1,196 additions and 628 deletions.
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -33,6 +33,7 @@ jobs:
         node-version: ${{ matrix.node-version }}
     - run: npm i
     - run: npm run cover
+    # run linter
     - run: |
         set -x;
         git status;
@@ -50,9 +51,11 @@ jobs:
                 node node_modules/eslint/bin/eslint $jsChanges;
             fi
         fi
-    # - run: npm run lint
+    # check types
+    - run: npm run update-types
     - run: node_modules/.bin/tsc --noImplicitAny --strict --noUnusedLocals --noImplicitReturns --noUnusedParameters --noImplicitThis ace.d.ts
     - run: npm run typecheck
+    - run: git diff --exit-code ./ace-modes.d.ts ./ace.d.ts
     - uses: codecov/codecov-action@v3
       with:
         token: d8edca4b-8e97-41e5-b54e-34c7cf3b2d47