Merge pull request #2052 from ajnart/1676-custom-favicon-does-not-red…

…nder
ajnart · May 16, 2024 · 2bf4231 · 2bf4231
2 parents 042a381 + 84f57bb
commit 2bf4231
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -19,6 +19,7 @@
     "prettier:check": "prettier --check \"**/*.{ts,tsx}\"",
     "prettier:write": "prettier --write \"**/*.{ts,tsx}\"",
     "test": "SKIP_ENV_VALIDATION=1 vitest",
+    "test:docker": "yarn run turbo build && yarn test:run && docker build . -t homarr:local-dev && docker run -p 7575:7575 --name homarr-dev homarr:local-dev",
     "test:ui": "SKIP_ENV_VALIDATION=1 vitest --ui",
     "test:run": "SKIP_ENV_VALIDATION=1 vitest run",
     "test:coverage": "SKIP_ENV_VALIDATION=1 vitest run --coverage",
@@ -241,4 +242,4 @@
       ]
     }
   }
-}
+}
diff --git a/src/components/layout/Meta/BoardHeadOverride.tsx b/src/components/layout/Meta/BoardHeadOverride.tsx
@@ -1,5 +1,4 @@
 import Head from 'next/head';
-import React from 'react';
 import { useConfigContext } from '~/config/provider';
 import { firstUpperCase } from '~/tools/shared/strings';
 
@@ -19,9 +18,9 @@ export const BoardHeadOverride = () => {
 
       {faviconUrl && faviconUrl.length > 0 && (
         <>
-          <link rel="shortcut icon" href={faviconUrl} />
+          <link key="favicon" rel="shortcut icon" href={faviconUrl} />
 
-          <link rel="apple-touch-icon" href={faviconUrl} />
+          <link key="favicon-apple" rel="apple-touch-icon" href={faviconUrl} />
         </>
       )}
     </Head>

diff --git a/src/components/layout/Meta/CommonHead.tsx b/src/components/layout/Meta/CommonHead.tsx
@@ -7,12 +7,12 @@ export const CommonHead = () => {
   return (
     <Head>
       <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1" />
-      <link rel="shortcut icon" href="/imgs/favicon/favicon.svg" />
+      <link key="favicon" rel="shortcut icon" href="/imgs/favicon/favicon.svg" />
 
       <link crossOrigin="use-credentials" rel="manifest" href="/site.webmanifest" />
 
       {/* configure apple splash screen & touch icon */}
-      <link rel="apple-touch-icon" href="/imgs/favicon/favicon.svg" />
+      <link key="favicon-apple" rel="apple-touch-icon" href="/imgs/favicon/favicon.svg" />
       <meta name="apple-mobile-web-app-title" content="Homarr" />
 
       <meta name="apple-mobile-web-app-capable" content="yes" />