Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Environment Variables for CONFIGS_PATH & ICONS_PATH #1446

Closed
oben01 opened this issue Oct 3, 2023 · 3 comments
Closed

Add Environment Variables for CONFIGS_PATH & ICONS_PATH #1446

oben01 opened this issue Oct 3, 2023 · 3 comments
Labels
✨ Feature A feature you'd like to be added ❌ Invalid for 1.0 This issue will no longer be relevant in 1.0 (Other implementation) Stale

Comments

@oben01
Copy link

oben01 commented Oct 3, 2023

Description

Thank you for all your hard work and commitment to making Homarr an exceptional open-source project.
I'd like to mention that I am using Homarr in a homelab environment, where it has proven to be a valuable tool for my personal projects and experimentation.

I propose adding support for environment variables in the project's configuration, specifically enabling the setting of environment variable paths to volumes from Kubernetes. This enhancement would allow users and deployers to configure the project dynamically based on their specific deployment environment and easily link environment variables to Kubernetes volumes.

Environment Variables to add :

CONFIGS_PATH: This environment variable would represent the path to the configuration files, linked to a Kubernetes volume.
ICONS_PATH: This environment variable would represent the path to the icons directory, linked to a Kubernetes volume.

The addition of environment variables linked to Kubernetes volumes will enhance the usability and flexibility of the project, making it easier for users to deploy and configure the project in various environments, including homelabs and Kubernetes clusters.

Kubernetes manifest example :

apiVersion: v1
kind: Pod
metadata:
  name: homarr-pod
spec:
  containers:
    - name: homarr
      image: ghcr.io/ajnart/homarr:latest
      ports:
        - containerPort: 7575
      volumeMounts:
        - name: configs-volume
          mountPath: /app/data/configs
        - name: icons-volume
          mountPath: /app/public/icons
  volumes:
    - name: configs-volume
      hostPath:
        path: /your-host-path/homarr/configs
    - name: icons-volume
      hostPath:
        path: /your-host-path/homarr/icons

Your feedback and input on this proposal are highly appreciated. Thank you for your attention to this request, and thank you once again for your outstanding work on Homarr.

Priority

Medium (Would be very useful)

@oben01 oben01 added the ✨ Feature A feature you'd like to be added label Oct 3, 2023
@manuel-rw
Copy link
Collaborator

manuel-rw commented Oct 3, 2023

Hello, thank you for this request. @Meierschlumpf and @ajnart , what do you think about this? This should be doable using the env validation script, right? Perhaps it would also make sense to allow the same for the database (upcoming authentication).

Copy link

github-actions bot commented Jan 1, 2024

Hello 👋, this issue has been open for 60 without activity. Please close this issue if it's no longer relevant or has been resolved. Still relevant? Simply reply and I'll mark it as active.

@github-actions github-actions bot added the Stale label Jan 1, 2024
@Meierschlumpf Meierschlumpf added the ❌ Invalid for 1.0 This issue will no longer be relevant in 1.0 (Other implementation) label Jan 10, 2025
@Meierschlumpf
Copy link
Collaborator

This is no longer relevant for 1.0 as those mounts do no longer exist.

@Meierschlumpf Meierschlumpf closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Homarr Kanban Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature A feature you'd like to be added ❌ Invalid for 1.0 This issue will no longer be relevant in 1.0 (Other implementation) Stale
Projects
Archived in project
Development

No branches or pull requests

3 participants