-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ping Error to https on local net (UNPROCESSABLE_CONTENT 422) #1784
Comments
Chances are that local IP's don't use https as this is provided by reverse proxies and under domain names. |
Some of my services such as the NAS, the router, or portainer among others, are forced to https even locally and do not open anything with http and returns 400 |
if they are apps with no integration, set them to http and add 400 in the list of accepted networks. I'll look into what changes where done that could make that happen. |
If I set them to http and add 400 in the list of accepted networks, the ping is green ok, but then when I click, it does not open the service, it opens the 400 error page. and then homarr does not make sense |
Sorry I wasn't clear, set the internal to http, external to https. |
same here... adding 400 does not change status - still fetch failed. Going back to 0.14.2 helps but not my favourite solution 😉 |
I don't understand how downgrading could help since we literally didn't touch the ping function for this update 🤔 |
I also back to 0.14.1 |
The same thing happens to me. |
happening for me on HTTPS sites that have invalid certs like NET::ERR_CERT_AUTHORITY_INVALID which worked before the latest update |
Are your certificates self signed? |
They are self signed and are the correct protocol (HTTPS). I will look in to getting you some logs. |
1704328121620.log |
Same here, 0.14.3 has issue with pings on some services, rolled back to 0.14.1 and all good again. |
Thanks the log. homarr/src/server/api/routers/app.ts Lines 32 to 38 in e208693
Using git blame, the author is @ajnart : @ajnart can you explain your idea behind the headers? These could definitely interfere with some services and are definitely not needed, since we parse no data nor does the returned data matter in any way. |
You're right this issue is happening since my last commit. I might've put that fetch code there for some unrelated tests and forgot to delete it later. We merged the docker import feature quite late so we didn't detect the changes in the ping system. I will roll back the changes and release them along with the next version |
@manuel-rw The crash might be due to the application/json header crashing if the content of the ping is not json and is for example HTML |
I am having issues replicating the issue, for me pinging anything with HTTPs locally hosted creates an error, Http UNPROCESSABLE_CONTENT 422. Even when using the code from previous version it returns an error for me. Could anyone share their setup / a minimal reproduction of the error ? |
I believe I may found the answer of what is happening in this question at Stackoverflow. It is consistent with the removal of the https from app.ts on line 4, possibly in favor of the fetch method, and the lack of the "rejectUnauthorized", which would circunvent the issue with self signed certificates. I don't have the means to build a POC to prove it, but it may help @ajnart on getting to a fix. |
Environment
Docker
Version
0.14.3
Describe the problem
The ping to the apps on the local network using the https protocol returns an error "unexpected response: fetch failed"
The error happens for example with the url of the router or the nas, such as: "https://192.168.x.x" or "https://192.168.x.x:yyyy"
In apps with "https://dominio.com:puerto" the ping works ok
And in apps with "http://19.168..x.x:yyyyy" it also works ok
Logs
Context
No response
Please tick the boxes
The text was updated successfully, but these errors were encountered: