Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noreferer mode needed for links #1933

Closed
poormonitor opened this issue Feb 28, 2024 · 4 comments · Fixed by homarr-labs/homarr#1915
Closed

Noreferer mode needed for links #1933

poormonitor opened this issue Feb 28, 2024 · 4 comments · Fixed by homarr-labs/homarr#1915
Labels
✨ Feature A feature you'd like to be added Fixed in 1.0 This issue has been fixed in our upcoming version 1.0 and is not crucial enough to be backported good first issue Good for newcomers

Comments

@poormonitor
Copy link

Description

Some applications (eg. qBittorrent returns 'Unauthorized' if the referrer is not in the accordance with the host) may have abnormal response if the referrer header has been sent. The current Homarr does not add noreferrer or similar configuration for a tag in the homepage.
It would be better if there is a toggle to set if the link brings "rel=noreferrer" to prevent abnormal response from happening.

Priority

Low (Nice-to-have)

@poormonitor poormonitor added the ✨ Feature A feature you'd like to be added label Feb 28, 2024
Copy link

Hi 👋. Thank you for submitting your first issue to Homarr. Please ensure that you've provided all nessesary information. You can use the three dots > Edit button to update your post with additional images and information. Depending on the current volume of requests, the team should get in conact with you shortly.

@ajnart
Copy link
Owner

ajnart commented Apr 18, 2024

Agreed. I believe you might be able to solve this issue with an llm if you can find the time to do so. In the meantime I'm tagging this as a "Good first issue" for anyone looking to make a contribution 😉

@H3phaist0s
Copy link

I came across this issue while setting up my dashboard and was frustrated by being unable to navigate directly to my QBit torrent application. I've created a PR for this issue. #2048

bebsworthy added a commit to bebsworthy/homarr that referenced this issue Sep 10, 2024
SeDemal pushed a commit that referenced this issue Sep 15, 2024
Meierschlumpf added a commit that referenced this issue Oct 18, 2024
* fix: app ping retry interval

* Bugfix for dynamic urls not properly replaces on Search (#2124)

* Bugfix for search items

* Fixing server side rendering issues

* Add rel="noreferrer" to link AppTile.tsx (#2126)

reference: 
Issue: #1933
PR comment: #2048 (comment)

* fix: Make timer button show only to admins (#2143)

* fix: wrong redirect url for oidc requests #1909 (#2149)

* fix: wrong redirect url for oidc requests #1909

* fix: login not working with https

* chore: New Crowdin updates (#2123)

* New translations health-monitoring.json (Greek)

* New translations login.json (French)

* New translations customize.json (French)

---------

Co-authored-by: Manuel <30572287+manuel-rw@users.noreply.github.com>
Co-authored-by: Jelte Lagendijk <j3lte@users.noreply.github.com>
Co-authored-by: Boyd <bebsworthy@gmail.com>
Co-authored-by: SeDemal <Tagaishi@hotmail.ch>
Co-authored-by: Thomas Camlong <thomas@ajnart.fr>
@Meierschlumpf Meierschlumpf added the Fixed in 1.0 This issue has been fixed in our upcoming version 1.0 and is not crucial enough to be backported label Jan 10, 2025
@Meierschlumpf
Copy link
Collaborator

With the mentioned pull request above homarr-labs/homarr#1915 this will be fixed in 1.0. It also was already fixed in 0.15.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature A feature you'd like to be added Fixed in 1.0 This issue has been fixed in our upcoming version 1.0 and is not crucial enough to be backported good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants