-
-
Notifications
You must be signed in to change notification settings - Fork 291
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look forward to adding the new "homarr_" variable. #2153
Comments
Hi, this is a nice idea. The only problem I can see with your suggestion, is that there's no easy way of doing it when IP's have to be taken into consideration. (Which is why we're using the tldts dependency in the first place. |
Sorry. I haven't understood it.I don't understand why IP addresses cause difficulties. If you have time to explain it to me, I will try my best to make some suggestions. How about set My English level can only express the basic meaning, can not use honorifics. But thank you very much for your efforts in the development process. |
It's about how you handle the address. The very basis is that you may use different addresses to access homarr, be it "homarr.domain.tld" or "192.168.0.2:7575". When you need to parse this address, both use dots, so you can't simply parse elements by splitting between the dots. |
In the example I provided, I use a private address at home and a public address while traveling, but with different ports, which prevents me from using Homarr properly with the existing variable configuration. |
Yes, that is why I already mentioned that adding the port is a good idea of itself. The part that I think is harder to implement is the "homarr_domain[x]", because of IPs. |
But this still doesn’t solve the issue of Homarr using different subdomains for other services. Whether it’s an IP or a domain name, returning the data to the user and allowing them to use slicing to get the necessary information might be a good option. Of course, I’m not entirely familiar with JavaScript, so I might be missing something in my considerations. |
For future reference, please voice your concern, that are related to PRs, in the PR. Thanks 👍 |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Description
Look forward to adding the new "homarr_" variable.
Homarr uses a set of "homarr_" variables like
homarr_base
to provide external access urls. But I'm looking forward to adding the new "homarr_" variable. In particularhomarr_domain[index]
andhomarr_port
.About
homarr_domain[index]
I noticed that the latest PR Use Public Suffix for homarr_domain #2147 tried to change the ability to get domain names.But then it would seem like an infinite number of new variables would need to be defined for multiple domains.
It is recommended to use a list-like approach to get the elements. Using index for different level domain name, like
homarr_domain[4]
forhomarr.myMachine.domain.tld
,homarr_domain[2]
to get thedomain.tld
. Or some other way.About
homarr_port
Also, we want to add a
homarr_port
variable to get the port, which is important in cases where different hostnames or URIs are used to differentiate services on the same port(different ports for internal and external networks).The desired effect
For
Can use
[homarr_protocol]://webapp.[homarr_domain[4]]:[homarr_port]
for all entrypoints. But now I couldn't configure ports 80 and 443 at a public address, so I have to set up multiple dashboards for both internal and external networks, andhomarr_domain
variables are completely unusable.Priority
Medium (Would be very useful)
The text was updated successfully, but these errors were encountered: