New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated tab and pill creation and fixed rendering #948

Open

kuro337 wants to merge 2 commits into akinsho:main from kuro337:groups_updates

kuro337 commented Jul 20, 2024

Hey Akin, apologies sir - the PR was quite big - I will make an incremental PR.

This was the main update - for the tab and pill rendering creation for the groups.

All the changes are in the groups file alone now -

Fixed/enhanced the separator.tab and separator.pill logic (lines 47-157)
Fixed the render function (lines 628:700)
Added a function to remove a buffer from the group to have a more flexible grouping approach.

Let me know if there is any discussion to be had - I tried adding descriptive comments everywhere!


          Updated tab and pill creation and fixed rendering

8a9c625

kuro337 mentioned this pull request

Closed


          groups initialization using display name as primary, name as fallback

56e6c41

zqqqqz2000 commented Oct 9, 2024

These features are so great, when merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet