Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher level api for typical usage #37

Closed
patriknw opened this issue Oct 5, 2023 · 4 comments
Closed

Higher level api for typical usage #37

patriknw opened this issue Oct 5, 2023 · 4 comments

Comments

@patriknw
Copy link
Member

patriknw commented Oct 5, 2023

We have many channels that the user must create and then we use them to glue together the different components. That might give us high flexibility of combining different components with each other. At some point I think we should review that with the DX hat on and see what we can make easier for the normal cases.

Originally posted by @patriknw in #36 (comment)

In that PR we combine akka_projection_rs_grpc::producer with akka_projection_rs_storage. Maybe that could be combined into a higher level user api, which could create the channels.

@huntc
Copy link
Contributor

huntc commented Oct 5, 2023

Higher level abstractions may be possible. One thing I’ve avoided is spawning within the library, as this then ties you to an executor implementation.

@huntc
Copy link
Contributor

huntc commented Nov 14, 2023

https://github.com/lightbend/akka-projection-temp/pull/21 reduces channel creation significantly. How's it looking w.r.t. to this issue given that PR?

@patriknw
Copy link
Member Author

Great improvements, I think this issue can be closed and we add more specific issues if we have any further suggestions.

@huntc
Copy link
Contributor

huntc commented Nov 14, 2023

Fixed by #126

@huntc huntc closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants