Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the applicability of tags for the edge #38

Open
huntc opened this issue Oct 7, 2023 · 0 comments
Open

Consider the applicability of tags for the edge #38

huntc opened this issue Oct 7, 2023 · 0 comments

Comments

@huntc
Copy link
Collaborator

huntc commented Oct 7, 2023

From Patrik:

We have found that tags is a pretty good way to filter events (consumer defined filters, evaluated on producer side). Without tags those filters can only be on entity ids (exact or regex). I think we have been and still are uncertain about how useful consumer defined filters are for the case when edge is producer. I guess the consumer would be interested in all events from the edge in most cases, and the edge itself decides what to publish (producer defined filter). I would say that tag filters can be added when we have more important things in place. Also depends on effort, if it's a small thing to add tagging support we can just do it.

We now have a WithTags trait for envelopes. At present, it'll always return an empty vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant