Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require /certs/ folder #231

Closed
ignasi35 opened this issue Jun 7, 2018 · 3 comments
Closed

Don't require /certs/ folder #231

ignasi35 opened this issue Jun 7, 2018 · 3 comments
Milestone
invalid

Comments

@ignasi35
Copy link
Contributor

ignasi35 commented Jun 7, 2018

GrpcClientSettings#certificate is the file name of a CA cert to trust.

We shouldn't require the trusted CA cert to be placed in /certs/.

Related to #230
@ignasi35
Copy link
Contributor Author

ignasi35 commented Jun 7, 2018

Actually, fix the FIXME

@raboof
Copy link
Contributor

raboof commented Jun 27, 2018

Also related to #89

@raboof
Copy link
Contributor

raboof commented Aug 6, 2018

This was fixed as part of #266

@raboof raboof closed this as completed Aug 6, 2018
@raboof raboof added this to the invalid milestone Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
invalid
Development

No branches or pull requests
2 participants
@raboof @ignasi35