Skip to content

Commit

Permalink
test: Harden Integration Tests for AppVersionRevision (#1239)
Browse files Browse the repository at this point in the history
* test: Harden Integration Tests for AppVersionRevision

* expected 3 pods when rollout is completed

* failed in ci with 4 pods, one of which was from old revision
  • Loading branch information
patriknw authored Dec 12, 2023
1 parent e4cb0d5 commit 3fe9dd1
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ testRevisionInPodsLog () {

# the two lines below ensure a rollout is fully completed, before we look at the logs for updated revision
# if not filtering out Terminated or pods that are not not ready (0/1) we will see previous revisions in the logs
[ `kubectl get pods -n $NAMESPACE | grep Terminating | wc -l` -ne 0 ] && continue # loop again until no Terminating nods in the list
[ `kubectl get pods -n $NAMESPACE | grep Running | wc -l` -ne 3 ] && continue # loop again until 3 pods running
[ `kubectl get pods -n $NAMESPACE | grep Terminating | wc -l` -ne 0 ] && continue # loop again until no Terminating pods in the list
[ `kubectl get pods -n $NAMESPACE | grep ContainerCreating | wc -l` -ne 0 ] && continue # loop again until no new pods in the list
[ `kubectl get pods -n $NAMESPACE | grep 0/1 | wc -l` -eq 0 ] && break # exit the loop once we only have READY (1/1) pods
done

Expand Down

0 comments on commit 3fe9dd1

Please sign in to comment.