Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Deferred compose better #22658

Closed
johanandren opened this issue Mar 30, 2017 · 4 comments
Closed

Make Deferred compose better #22658

johanandren opened this issue Mar 30, 2017 · 4 comments
Assignees
@johanandren
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding 3 - in progress Someone is working on this ticket t:typed
Milestone
2.5.99-TYPED-M1

Comments

@johanandren
Copy link
Member

johanandren commented Mar 30, 2017 •
edited by patriknw
Loading

Currently Deferred can only be used as the outermost Behavior as it expects a PreStart as the first message. Roland mentions in akka/akka-meta#46 that it should be fixable.
@johanandren johanandren added 3 - in progress Someone is working on this ticket t:typed labels Mar 30, 2017
@johanandren johanandren self-assigned this Mar 30, 2017
@patriknw
Copy link
Member

Possibly related: #20205

@patriknw patriknw added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Mar 31, 2017
@patriknw
Copy link
Member

Possibly related: #22661

@rkuhn
Copy link
Contributor

rkuhn commented Mar 31, 2017

Fixing this is implicit to the removal of the PreStart signal, there is no fundamental reason for the assertion that currently makes composition harder than it should be.

@johanandren
Copy link
Member Author

@rkuhn Yes, maybe the name of the ticket is somewhat misleading, but that's the end result we want to end up with and I wasn't entirely sure what needed to be done to get there. I will start with the "interpreter" ticket and see if removing PreStart follows naturally in the work there.

@johanandren johanandren mentioned this issue Apr 3, 2017
Merged
@2m 2m closed this as completed Apr 4, 2017
@2m 2m added this to the 2.5.x milestone Apr 4, 2017
@patriknw patriknw modified the milestones: 2.5.x, 2.5.99-TYPED-M1 May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanandren johanandren

Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding 3 - in progress Someone is working on this ticket t:typed
Projects
None yet
Milestone
2.5.99-TYPED-M1
Development

No branches or pull requests
4 participants
@patriknw @2m @rkuhn @johanandren