Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lastPromotion.freight details to Projects page stages #3481

Open
1 of 3 tasks
mimartin12 opened this issue Feb 10, 2025 · 4 comments
Open
1 of 3 tasks

Add lastPromotion.freight details to Projects page stages #3481

mimartin12 opened this issue Feb 10, 2025 · 4 comments

Comments

@mimartin12
Copy link
Contributor

mimartin12 commented Feb 10, 2025

Checklist

  • I've searched the issue queue to verify this is not a duplicate feature request.
  • I've pasted the output of kargo version, if applicable.
  • I've pasted logs, if applicable.

Proposed Feature

Displaying the commit/image/chart version for each stage that are present on the Project's page would show engineers what has been deployed.

Motivation

This would provide "at-a-glance" visibility to members on what has been deployed from the Projects page, without the need to drill deeper into the project itself.

Example: A QA engineer wants to view what version has gone out into the test environment. They already have access to Kargo to view deployments, they can simply see the version from the project page.

Image

Suggested Implementation

I was able to hack something together into ui/src/features/common/stage-tag.tsx that displayed the promotion status into the stage. I don't think this is as scalable as I would like it to be, hence "hack". I am limited by my experience with React.

Example

@krancour
Copy link
Member

I'm not sure how we'd make this look nice for Stages that have multiple Freight (from different Warehouses) or even those that have a single piece of Freight, but that Freight references multiple artifacts.

I think we could potentially do it for Stages/Freight where there's precisely one artifact.

@Marvin9 wdyt?

@krancour krancour assigned krancour and Marvin9 and unassigned krancour Feb 11, 2025
@mimartin12
Copy link
Contributor Author

I'm not sure how we'd make this look nice for Stages that have multiple Freight (from different Warehouses) or even those that have a single piece of Freight, but that Freight references multiple artifacts.

I think we could potentially do it for Stages/Freight where there's precisely one artifact.

@Marvin9 wdyt?

This is a good point, what about moving the versions down to the tooltip that is provided on-hover, example:

Image

The list of freights are already provided there, so attaching additional information seems simple enough.

@Marvin9
Copy link
Contributor

Marvin9 commented Feb 12, 2025

I am afraid when there are more stages how it will look, eventually we have to hide some things anyways. Me and @rpelczar are thinking to have summary view instead of individual details. For example x stages, y failed. What do you think about this?

@krancour
Copy link
Member

@Marvin9 I believe I agree with the idea of a summary here. imho, the issue with the project list page isn't too little information, it's too much. I know this is almost exactly the opposite of what @mimartin12 is requesting. We don't need to rush this decision. Maybe @jessesuen has an opinion as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants