fix: improve debug information http step
#3496
Merged
+27
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hiddeco
force-pushed
the
imprv-http-step
branch
from
50c36c4 to
0de3ce0
Compare
This adds the HTTP response code to the error message in case of failures, and provides a `trace` level log message with the HTTP response. Combined, this should make it easier to debug a variety of error scenarios a user may run into when trying to write a `http` directive. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
imprv-http-step
branch
from
0de3ce0 to
7ef9a13
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3496 +/- ##
==========================================
+ Coverage 52.25% 52.27% +0.01%
==========================================
Files 290 290
Lines 26307 26317 +10
==========================================
+ Hits 13747 13757 +10
Misses 11810 11810
Partials 750 750 ☔ View full report in Codecov by Sentry. |
krancour
approved these changes
Feb 15, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 15, 2025
Signed-off-by: Hidde Beydals <[email protected]> (cherry picked from commit bee9f4a)
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the HTTP response code to the error message in case of failures, and provides a
tracelevel log message with the HTTP response. Combined, this should make it easier to debug a variety of error scenarios a user may run into when trying to write ahttpdirective.