Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial updates to recruitment FAQs #157

Merged
merged 34 commits into from
Nov 15, 2024
Merged

Initial updates to recruitment FAQs #157

merged 34 commits into from
Nov 15, 2024

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Jul 2, 2024

WIP.

Closes #154

Co-authored-by: Nathan Simpson <[email protected]>
Co-authored-by: Isabel Fenton <[email protected]>
Co-authored-by: Katriona Goldmann <[email protected]>
@penelopeysm penelopeysm marked this pull request as draft July 2, 2024 14:08
@IFenton
Copy link
Contributor

IFenton commented Aug 8, 2024

I'm doing some work on this, so I'll be requesting reviews shortly

@penelopeysm
Copy link
Member Author

I've managed to bug Martin/Eric to get the old HackMD to redirect to here, so that's a success 😄

Since we've advertised this link quite a fair bit (or links which link to this), I'm going to try to get this into a reviewable state this week.

It doesn't have to have all the answers (we can continue improving it over time), but it should at least be an improvement over what we have right now.

@penelopeysm penelopeysm self-assigned this Sep 16, 2024
@penelopeysm penelopeysm changed the title Outline some areas for updates to recruitment FAQs Initial updates to recruitment FAQs Sep 16, 2024
@penelopeysm penelopeysm force-pushed the faqs_update branch 2 times, most recently from 1950a9d to b83259b Compare September 17, 2024 23:23
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@IFenton IFenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but apart from that it's looking great

content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Show resolved Hide resolved
Co-authored-by: Isabel Fenton <[email protected]>
Copy link

@edaub edaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. A few things I think we should revise and a few edits, but otherwise happy to merge this once these are done.

content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
content/docs/join_us/recruitment_FAQs.md Outdated Show resolved Hide resolved
@penelopeysm
Copy link
Member Author

penelopeysm commented Oct 17, 2024

Thank you so much @edaub!

I've asked one more person for permission to add their code example to the FAQs, and will add it if they agree Added now, but apart from that I'm done editing.

@IFenton
Copy link
Contributor

IFenton commented Nov 15, 2024

Finally got round to doing a last look through - I'm happy with this now

@penelopeysm penelopeysm merged commit ae9a0bb into main Nov 15, 2024
5 checks passed
@penelopeysm penelopeysm deleted the faqs_update branch November 15, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to recruitment FAQs
5 participants