Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonic oscillator model #51

Open
ZofiaTr opened this issue Jul 18, 2018 · 12 comments
Open

Harmonic oscillator model #51

ZofiaTr opened this issue Jul 18, 2018 · 12 comments
Assignees

Comments

@ZofiaTr
Copy link
Collaborator

ZofiaTr commented Jul 18, 2018

It will be possible to do one dimensional harmonic oscillator. I will add the section into the userguide.

Teaser:
ho

@ZofiaTr ZofiaTr added the TBD label Jul 18, 2018
@FrederikHeber
Copy link
Collaborator

Great. This looks very good!

Is this still simply kinetic energy or already mean loss?

@ZofiaTr
Copy link
Collaborator Author

ZofiaTr commented Jul 18, 2018

That's the configurational marginal distribution, i.e. distribution of weight0

@ZofiaTr
Copy link
Collaborator Author

ZofiaTr commented Jul 24, 2018

In which section of the userguide can I put it? Simulation?

@FrederikHeber
Copy link
Collaborator

Please add it as an extra file, for example +doc/userguide/reference_simulation_harmonic_oscillator.txt+.

There are so many changes to the userguide with this version and it needs to be linked from other parts , too. I'll do this when I merge the branches.

Thanks!

@ZofiaTr
Copy link
Collaborator Author

ZofiaTr commented Jul 25, 2018

Great, thanks, I'm on it!

@ZofiaTr
Copy link
Collaborator Author

ZofiaTr commented Jul 25, 2018

I was also thinking, that it might be very useful if Ben @TeeBee2 could read some chosen parts of the userguide. I suggested some modifications as mentioned in #51 #50 #46 and updated them in the branch Userguide_Samplers, but I might be naturally wrong in some sense, so it would be great to have his opinion. What do you think @FrederikHeber ?

@bigpuma-dev
Copy link
Collaborator

Yes, I am happy to do so but must be next week. So busy here. - Ben

@FrederikHeber
Copy link
Collaborator

I absolutely agree that Ben should read the userguide as well. However, this issue is the not the place for this. I'll open a new ticket.

@ZofiaTr
Copy link
Collaborator Author

ZofiaTr commented Jul 25, 2018

Pushed to Userguide_Samplers

@ZofiaTr ZofiaTr closed this as completed Jul 25, 2018
@FrederikHeber
Copy link
Collaborator

I am not very happy with the quality of the text on the harmonic oscillator. However, I will still merge the branch.

The second code piece was not fully working.
And the explanations are scarce: Why is it a Gaussian probability distibution? It is simple to explain from the mean square loss and "exponential function of energy equals probability".
Moreover, the harmonic oscillator would have been a chance to explain how averages are obtained and in this case to compare to analytically known values. This could form a very nice connection to the analysis sections in the quickstart part of the guide.

@FrederikHeber FrederikHeber reopened this Jul 26, 2018
@FrederikHeber
Copy link
Collaborator

I have added tests on the example code after having extracted them into external files.

@FrederikHeber
Copy link
Collaborator

Postponing remainder of changes until after v0.9.

@FrederikHeber FrederikHeber removed this from the v0.9 milestone Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants