Skip cmethods for 3cities #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griff-rees
reviewed
May 21, 2024
griff-rees
reviewed
May 21, 2024
There was a problem hiding this comment.
There are two files in /compose/ meant to provide this functionality
/compose/linux-compose.yml/compose/mac-compose.yml
See a new ticket bullet point on improving documentation: Improvedockerdocumentation and configuration #150
griff-rees
reviewed
May 21, 2024
There was a problem hiding this comment.
See python/clim_recal/debiasing/preprocess_data.py in https://github.com/alan-turing-institute/clim-recal/pull/145/files. This should address two ways in which this module is imported.
griff-rees
reviewed
May 21, 2024
There was a problem hiding this comment.
I think both preprocess_data.py and run_cmethods.py need refactoring. It maybe be safer to remove this script or add a discalimer.
|
The main purpose of this branch and PR was to share the process of getting the server up and running. Any changes to the code are purely to support that purpose and are superseded by other changes or issues. I will close this branch/PR unmerged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.