Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss train / validation dataset split #17

Open
dfulu opened this issue Aug 9, 2024 · 0 comments
Open

Discuss train / validation dataset split #17

dfulu opened this issue Aug 9, 2024 · 0 comments

Comments

@dfulu
Copy link
Collaborator

dfulu commented Aug 9, 2024

In the download client we explicitly have he train and validation datasets download to different zarr files. In the pytorch lightning datamodule we have separate dataloaders for train, validation, and test but assuming these are split out in time from the same zarr or set of zarrs. Therefore the download and the datamodule are perhaps assuming different things about how we expect people to be splitting the data to train models. We should think about this and bring these more into harmoney

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant