Skip to content

115 selective disclosure ssi update #410

115 selective disclosure ssi update

115 selective disclosure ssi update #410

Triggered via pull request November 27, 2023 16:30
Status Failure
Total duration 4m 16s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 25 warnings
build
Process completed with exit code 101.
redundant closure: trustchain-ffi/src/mobile.rs#L180
warning: redundant closure --> trustchain-ffi/src/mobile.rs:180:14 | 180 | .map_err(|err| FFIMobileError::FailedToRedactCredential(err))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `FFIMobileError::FailedToRedactCredential` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default
the `Err`-variant returned from this function is very large: trustchain-ffi/src/mobile.rs#L66
warning: the `Err`-variant returned from this function is very large --> trustchain-ffi/src/mobile.rs:66:54 | 55 | FailedToRedactCredential(ssi::ldp::Error), | ----------------------------------------- the largest variant contains at least 232 bytes ... 66 | fn check_proof_time(created_time: &DateTime<Utc>) -> Result<(), FFIMobileError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `mobile::FFIMobileError`, for example by boxing large elements or replacing it with `Box<mobile::FFIMobileError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err = note: `#[warn(clippy::result_large_err)]` on by default
the `Err`-variant returned from this function is very large: trustchain-ion/src/attestor.rs#L69
warning: the `Err`-variant returned from this function is very large --> trustchain-ion/src/attestor.rs:69:55 | 69 | pub fn signing_pk(&self, key_id: Option<&str>) -> Result<JWK, KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 224 bytes | = help: try reducing the size of `trustchain_core::key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<trustchain_core::key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-ion/src/attestor.rs#L43
warning: the `Err`-variant returned from this function is very large --> trustchain-ion/src/attestor.rs:43:52 | 43 | fn signing_key(&self, key_id: Option<&str>) -> Result<JWK, KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 224 bytes | = help: try reducing the size of `trustchain_core::key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<trustchain_core::key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-ion/src/attestor.rs#L38
warning: the `Err`-variant returned from this function is very large --> trustchain-ion/src/attestor.rs:38:31 | 38 | fn signing_keys(&self) -> Result<OneOrMany<JWK>, KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 224 bytes | = help: try reducing the size of `trustchain_core::key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<trustchain_core::key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err = note: `#[warn(clippy::result_large_err)]` on by default
the `Err`-variant returned from this function is very large: trustchain-core/src/utils.rs#L148
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/utils.rs:148:29 | 148 | pub fn decode(jwt: &str) -> Result<String, ssi::jws::Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 224 bytes | = help: try reducing the size of `ssi::ssi_jws::Error`, for example by boxing large elements or replacing it with `Box<ssi::ssi_jws::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/utils.rs#L143
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/utils.rs:143:47 | 143 | pub fn decode_verify(jwt: &str, key: &JWK) -> Result<String, ssi::jws::Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 224 bytes | = help: try reducing the size of `ssi::ssi_jws::Error`, for example by boxing large elements or replacing it with `Box<ssi::ssi_jws::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/key_manager.rs#L242
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/key_manager.rs:242:68 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes ... 242 | fn remove_keys(&self, did_suffix: &str, key_type: &KeyType) -> Result<(), KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/key_manager.rs#L207
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/key_manager.rs:207:10 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes ... 207 | ) -> Result<(), KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/key_manager.rs#L191
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/key_manager.rs:191:10 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes ... 191 | ) -> Result<(), KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/key_manager.rs#L151
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/key_manager.rs:151:10 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes ... 151 | ) -> Result<PathBuf, KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/key_manager.rs#L127
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/key_manager.rs:127:60 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes ... 127 | fn read_keys_from(&self, mut reader: Box<dyn Read>) -> Result<OneOrMany<JWK>, KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/key_manager.rs#L118
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/key_manager.rs:118:10 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes ... 118 | ) -> Result<JWK, KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/key_manager.rs#L99
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/key_manager.rs:99:10 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes ... 99 | ) -> Result<OneOrMany<JWK>, KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/key_manager.rs#L88
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/key_manager.rs:88:54 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes ... 88 | fn read_signing_keys(&self, did_suffix: &str) -> Result<OneOrMany<JWK>, KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/key_manager.rs#L75
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/key_manager.rs:75:10 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes ... 75 | ) -> Result<(), KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/key_manager.rs#L65
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/key_manager.rs:65:57 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes ... 65 | fn read_next_update_key(&self, did_suffix: &str) -> Result<JWK, KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/key_manager.rs#L59
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/key_manager.rs:59:52 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes ... 59 | fn read_update_key(&self, did_suffix: &str) -> Result<JWK, KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/key_manager.rs#L54
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/key_manager.rs:54:54 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes ... 54 | fn read_recovery_key(&self, did_suffix: &str) -> Result<JWK, KeyManagerError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
large size difference between variants: trustchain-core/src/key_manager.rs#L13
warning: large size difference between variants --> trustchain-core/src/key_manager.rs:13:1 | 13 | / pub enum KeyManagerError { 14 | | /// Key does not exist. 15 | | #[error("Key does not exist.")] 16 | | FailedToLoadKey, | | --------------- the second-largest variant carries no data at all ... | 40 | | SSIJWKError(#[from] ssi::jwk::Error), | | ------------------------------------ the largest variant contains at least 224 bytes 41 | | } | |_^ the entire enum is at least 224 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 40 | SSIJWKError(#[from] Box<ssi::jwk::Error>), | ~~~~~~~~~~~~~~~~~~~~
the `Err`-variant returned from this function is very large: trustchain-core/src/controller.rs#L39
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/controller.rs:39:43 | 39 | fn generate_next_update_key(&self) -> Result<(), KeyManagerError>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ::: trustchain-core/src/key_manager.rs:40:5 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/controller.rs#L37
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/controller.rs:37:31 | 37 | fn recovery_key(&self) -> Result<JWK, KeyManagerError>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ::: trustchain-core/src/key_manager.rs:40:5 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/controller.rs#L35
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/controller.rs:35:34 | 35 | fn next_update_key(&self) -> Result<Option<JWK>, KeyManagerError>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ::: trustchain-core/src/key_manager.rs:40:5 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: trustchain-core/src/controller.rs#L33
warning: the `Err`-variant returned from this function is very large --> trustchain-core/src/controller.rs:33:29 | 33 | fn update_key(&self) -> Result<JWK, KeyManagerError>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ::: trustchain-core/src/key_manager.rs:40:5 | 40 | SSIJWKError(#[from] ssi::jwk::Error), | ------------------------------------ the largest variant contains at least 224 bytes | = help: try reducing the size of `key_manager::KeyManagerError`, for example by boxing large elements or replacing it with `Box<key_manager::KeyManagerError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err = note: `#[warn(clippy::result_large_err)]` on by default
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/