Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible inconsistent state for autoscaling instance protection #23

Open
alanbover opened this issue Aug 28, 2017 · 0 comments
Open

Possible inconsistent state for autoscaling instance protection #23

alanbover opened this issue Aug 28, 2017 · 0 comments
Labels

Comments

@alanbover
Copy link
Owner

When we refresh an autoscaling group, we check if it's protected against scale in.

The function "SetASGInstanceProtection" first sets the protection to scale in on the autoscalingGroup, and then for all the instances.

If the call for protect the instances fails, deathnode will never try again to set those instances as protectedToScaleIn, leaving it in an inconsistent state.

The correct order should be:

  • Set all instances with protectToScaleIn
  • Set autoscaling group with protectToScaleIn flag
@alanbover alanbover added the bug label Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant