Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUA error in 11.0 - GetFactionInfoByID is gone #30

Open
raysmith59 opened this issue Jul 30, 2024 · 3 comments
Open

LUA error in 11.0 - GetFactionInfoByID is gone #30

raysmith59 opened this issue Jul 30, 2024 · 3 comments

Comments

@raysmith59
Copy link

They've changed a bunch of the reputation functions, they're now under C_Reputation. There may be more errors but this is the first that I saw.

3x OrderHallCommander/missionlist.lua:321: attempt to call global 'GetFactionInfoByID' (a nil value)
[string "@OrderHallCommander/missionlist.lua"]:321: in function <OrderHallCommander/missionlist.lua:313>
[string "=(tail call)"]: ?
[string "=[C]"]: ?

Locals:
self =

{
modules =
{
}
enabledState = true
defaultModuleLibraries =
{
}
baseName = "OrderHallCommander"
orderedModules =
{
}
hooks =
{
}
defaultModuleState = true
name = "OrderHallCommander_Missionlist"
moduleName = "Missionlist"
}
this = Frame {
Quantity = FontString {
}
itemID = 152959
IconBorder = Texture {
}
IconOverlay = Texture {
}
itemLink = "|cff0070dd|Hitem:152959::::::::60:269:::::::::|h[Argussian Reach Insignia]|h|r"
Icon = Texture {
}
}
tip = GameTooltip {
ATT_AttachComplete = true
ItemTooltip = Frame {
}
AllTheThingsOnTooltipClearedHook = true
BottomOverlay = Texture {
}
NineSlice = Frame {
}
textLeft1Font = "GameTooltipHeaderText"
textRight2Font = "GameTooltipText"
TopOverlay = Texture {
}
TextLeft1 = GameTooltipTextLeft1 {
}
StatusBar = GameTooltipStatusBar {
}
supportsDataRefresh = true
waitingForData = false
AllTheThingsProcessing = "|cff0070dd|Hitem:152959::::::::60:269:::::::::|h[Argussian Reach Insignia]|h|r"
processingInfo =
{
}
infoList =
{
}
shoppingTooltips =
{
}
updateTooltipTimer = 0.110000
TextRight1 = GameTooltipTextRight1 {
}
supportsItemComparison = true
textRight1Font = "GameTooltipHeaderText"
layoutType = "TooltipDefaultLayout"
textLeft2Font = "GameTooltipText"
TextRight2 = GameTooltipTextRight2 {
}
TextLeft2 = GameTooltipTextLeft2 {
}
}
factionID = 2170
(*temporary) = nil
(*temporary) = 2170
(*temporary) = "attempt to call global 'GetFactionInfoByID' (a nil value)"
addon =
{
modules =
{
}
allEquipments =
{
}
hooks =
{
}
db =
{
}
revision = "a796203"
name = "OrderHallCommander"
defaultModuleState = true
resourceFormat = "Cost: %d"
CfgRel = 147
ProfileOpts =
{
}
lastsection = "Release Notes"
help =
{
}
prettyversion = "2.3.2 (Revision: a796203)"
version = "2.3.2"
ItemOrder =
{
}
enabledState = true
allReputationGain =
{
}
DbDefaults =
{
}
OptionsTable =
{
}
numericversion = 0
_Apply =
{
}
baseName = "OrderHallCommander"
MenuLevels =
{
}
allArtifactPower =
{
}
wowhead_update = 1512310641
CfgDlg = "OrderHallCommander"
defaultModuleLibraries =
{
}
die = false
orderedModules =
{
}
lastChange = 1206.572000
}
artinfo = "*Artifact shown value is the base value without considering knowledge multiplier"
C =
{
silver =
{
}
cyan =
{
}
grey =
{
}
white =
{
}
green =
{
}
azure =
{
}
yellow =
{
}
orange =
{
}
red =
{
}
}
_G =
{
ERR_OUT_OF_CHI = "Not enough chi"
DH_HAVOC_CORE_ABILITY_2 = "Strong melee attack that consumes Fury. If it critical strikes, some Fury is refunded."
UNIT_NAMES_COMBATLOG_TOOLTIP = "Color unit names."
AchievementFrameStatsBG = AchievementFrameStatsBG {
}
LE_GAME_ERR_CHAT_RAID_RESTRICTED_TRIAL = 783
SPELL_FAILED_CUSTOM_ERROR_71 = "This partygoer wants to dance with you."
LE_GAME_ERR_PET_SPELL_TARGETS_DEAD = 421
ClassTrialTimerDisplayMixin =
{
}
MultiBarLeftButton7 = MultiBarLeftButton7 {
}
MerchantItem5AltCurrencyFrameItem1Text = MerchantItem5AltCurrencyFrameItem1Text {
}
OPTION_SHOW_ACTION_BAR5_TOOLTIP = "Attached to the left side of Action Bar 4 by default"
BINDING_NAME_NAMEPLATES = "Show Enemy Nameplates"
CHAT_HEADER_SUFFIX = ": "
COVENANT_MISSIONS_HEALTH = "Health"
PVPReadyDialogBottomArt = PVPReadyDialogBottomArt {
}
CALENDAR_RAID_RESET_DESCRIPTION = "%1$s resets at %2$s."
VuhDoNewOptionsPanelHotsHotsPanelHotIconsTextureSquaresDiagonalRadioButtonTextureSwatch = VuhDoNewOptionsPanelHotsHotsPanelHotIconsTextureSquaresDiagonalRadioButtonTextureSwatch {
}
AceConfigDialogTooltipTexture20 = AceConfigDialogTooltipTexture20 {
}
CinematicFrameRaidBossEmoteFrame = CinematicFrameRaidBossEmoteFrame {
}
VuhDoNewOptionsColorsModesNormalModePanelIcomingOpacCheckBox = VuhDoNewOptionsColorsModesNormalModePanelIcomingOpacCheckBox {
}
LE_GAME_ERR_ONLY_ONE_QUIVER =

@raysmith59 raysmith59 changed the title LUA error in 11.0 LUA error in 11.0 - GetFactionInfoByID is gone Jul 30, 2024
@raysmith59
Copy link
Author

I didn't get an error with this change:
--local faction,_,level=GetFactionInfoByID(factionID)
local factionData = C_Reputation.GetFactionDataByID(factionID)
local faction = factionData.name
local level = factionData.currentStanding

@Wraithlord2015
Copy link

API depreciation:

GetFactionInfoByID was replaced by C_Reputation.GetFactionDataByID

@raysmith59
Copy link
Author

I tested just changing the function call and it appears to work as well vs my more explicit solution, good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants