Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if use_fork is false, this should be ignored #3

Open
hsliuustc opened this issue Dec 17, 2021 · 1 comment
Open

if use_fork is false, this should be ignored #3

hsliuustc opened this issue Dec 17, 2021 · 1 comment

Comments

@hsliuustc
Copy link

fourierflow/fourierflow/modules/fourier_2d_factorized_parallel.py

Line 218 in 97e6cfb

if self.avg_outs:

@alasdairtran
Copy link
Owner

Yeah you're right! I had a go at running the experiment with avg_outs set to False, and it makes no difference to the loss (which makes sense since it's just a linear scaling factor, which the projection layer can easily learn). I'll probably remove this scaling altogether in the next iteration of experiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alasdairtran @hsliuustc