Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_retries on _safe_read is not-changeable #218

Closed
iTaybb opened this issue May 10, 2017 · 2 comments
Closed

max_retries on _safe_read is not-changeable #218

iTaybb opened this issue May 10, 2017 · 2 comments
Milestone
0.8

Comments

@iTaybb
Copy link
Contributor

iTaybb commented May 10, 2017

The number of max_retries is restricted to 8 on the signature of the _safe_read function.

I think it should be a variable that you can set, with something like musicbrainzngs.set_max_retries.

I can make the commits - do you have any objections for that?
@iTaybb
Copy link
Contributor Author

iTaybb commented May 10, 2017

Ah, sorry, I just saw that issue #174 is talking about that. I'll create the commits then

iTaybb added a commit to iTaybb/python-musicbrainzngs that referenced this issue May 10, 2017
@iTaybb
Added a _retries variable at the main module file (musicbrainz.py…
6ea48da 
…). Underscored so people only use if they know what they're doing.

Solved issues alastair#174 and alastair#218.

Signed-off-by: Itay Brandes <[email protected]>
@iTaybb iTaybb mentioned this issue May 10, 2017
Merged
@alastair alastair added this to the 0.7 milestone Sep 11, 2019
@alastair
Copy link
Owner

Fixed in #219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8
Development

No branches or pull requests
2 participants
@alastair @iTaybb