Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the musicbrainz server error on HTTP400 #80

Closed
alastair opened this issue Nov 13, 2012 · 1 comment
Closed

Expose the musicbrainz server error on HTTP400 #80

alastair opened this issue Nov 13, 2012 · 1 comment
Assignees
@alastair
Labels
improvement
Milestone
0.6

Comments

@alastair
Copy link
Owner

That is, the contents of <error><text>Invalid mbid.</text></error>
@alastair alastair mentioned this issue Mar 25, 2013
Open
@JonnyJD JonnyJD mentioned this issue Apr 21, 2013
Open
@JonnyJD JonnyJD mentioned this issue Nov 15, 2013
Merged
@JonnyJD
Copy link
Collaborator

JonnyJD commented Dec 4, 2013

This is not trivial, since we use build_opener from urllib, which raises HTTPError in that case and doesn't expose this information.

This might be something to implement together or after #123.

@alastair alastair added this to the 0.6 milestone Feb 6, 2014
alastair added a commit that referenced this issue Jul 22, 2014
@alastair
If an http error from musicbrainz has a message, read it
0d86fa2 
Error is added to the exception's `message` parameter.
Fixes #80

Signed-off-by: Alastair Porter <[email protected]>
@alastair alastair mentioned this issue Jul 22, 2014
Closed
alastair added a commit that referenced this issue Sep 23, 2014
@alastair
If an http error from musicbrainz has a message, read it
1e83f9f 
Only read the message from `cause` if it's an HTTP error.
Parse the error with an xml or json parser depending on the
webservice format.
Error is added to the exception's `message` parameter.
Fixes #80

Signed-off-by: Alastair Porter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alastair alastair

Labels
improvement
Projects
None yet
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

If an http error from musicbrainz has a message, read it alastair/python-musicbrainzngs
2 participants
@alastair @JonnyJD