Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"qisrc push --no-review" tries to set reviewers #97

Open
plemagourou opened this issue Jun 10, 2016 · 1 comment
Open

"qisrc push --no-review" tries to set reviewers #97

plemagourou opened this issue Jun 10, 2016 · 1 comment

Comments

@plemagourou
Copy link
Contributor

Even if qisrc push was launch with the option --no-review, qisrc tries to add reviewers and a failure warning is printed. The push command is well executed though.

Here are a few lines that show the problem:

qisrc push --no-review
Fetching gerrit
Total 0 (delta 0), reused 0 (delta 0)
remote: Processing changes: closed: 1, refs: 1, done
[...]
Adding reviewers... (user1, user2)
[...]
[WARN ]: Couldn't set reviewers
[WARN ]: The following command failed
['/usr/bin/ssh', '-p', '29418', 'user@server', 'gerrit', 'set-reviewers', '43ff328a54420d291a281d4a6c617178eb4e3fe3', '149a3583829455f9934128008e479a241e76f1eb', '--add user1', '--add user2']
Return code is 1
vbarbaresi pushed a commit that referenced this issue Jun 10, 2016
qisrc push: don't try to set reviewers when --no-review #97
e80994e 
There was some logic missing here, this option is seldom used
and needed a test

Change-Id: If026508c2a33e38c42bfb4b86293e316053e7779
@vbarbaresi
Copy link
Contributor

Indeed, fixed by #98

opennao pushed a commit that referenced this issue Jul 8, 2016
qisrc push: don't try to set reviewers when --no-review #97
8cb3945 
There was some logic missing here, this option is seldom used
and needed a test

Change-Id: If026508c2a33e38c42bfb4b86293e316053e7779
Reviewed-on: http://gerrit.aldebaran.lan/73252
Tested-by: gerrit
Reviewed-by: vbarbaresi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbarbaresi @plemagourou