Bugfix: Allow selecting scanning options for float and double #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KingJigglypuff try using this build. You can grab a built CI artifact on the Summary page. 
|
Resolves #191 Previously set value while viewing binary/word etc would influence scan. I verified unaligned option also works, though makes scanning take longer.
dreamsyntax
force-pushed
the
bugfix-allow-selecting-float-double-scanoptions
branch
from
1285d48 to
2bdf58d
Compare
cristian64
approved these changes
Feb 26, 2025
dreamsyntax
deleted the
bugfix-allow-selecting-float-double-scanoptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #191
Previously set value while viewing binary/word etc would influence scan.
I verified unaligned option also works, though doing so makes scanning take longer.
I don't really see why you'd want to use the other types, but I suppose it doesn't hurt to expose it either rather than forcing decimal.