Normalise whitespace in all C code

[pippijn]

In general, tabs are used for both indentation and alignment, but sometimes spaces are used for indentation, sometimes a mixture is used. We should normalise this to something. I would suggest tabs for indentation and spaces for alignment, so it looks good with any tab-width setting.

[pippijn]

Actually, I just checked, and that would change a lot of code. We should stay close to the original indentation, which assumes tab = 8 spaces, indents with tab and aligns with a mixture of both (tabs first, then spaces).

[pippijn]

There are other inconsistencies in formatting. We should prepare a document with coding style hints.

[edi-meier]

Just for fun I tried "indent -gnu, -linux, -kr, -orig". ccode.c does seem to resemble to any of them.
Maybe choose a common, i.e., well known coding style, whichever it might be.

[pippijn]

I have started a document on coding style and formatting/indentation guidelines in the wiki. These are gradually assembled from findings in the aldor source code. I am trying to create a well-founded set of guidelines in which people can find an answer to every question. Eventually, I will also want to enforce some of these guidelines (especially naming conventions). It's a lot of work to write all these things down, so if someone finds more guidelines, feel free to edit the wiki.

Also, I welcome feedback on the current guidelines, as well as ideas for additional guidelines that the current codebase does not follow. (E.g. the header inclusion order guideline is not followed anywhere, yet.)

[pbroadbery]

On Thu, Aug 1, 2013 at 12:59 AM, Pippijn van Steenhoven <
[email protected]> wrote:

I have started a document on coding style and formatting/indentation
guidelines in the wikihttps://github.com/pippijn/aldor/wiki/Coding-style.
These are gradually assembled from findings in the aldor source code. I am
trying to create a well-founded set of guidelines in which people can find
an answer to every question. Eventually, I will also want to enforce some
of these guidelines (especially naming conventions). It's a lot of work to
write all these things down, so if someone finds more guidelines, feel free
to edit the wiki.

Also, I welcome feedback on the current guidelines, as well as ideas for
additional guidelines that the current codebase does not follow. (E.g. the
header inclusion order guideline is not followed anywhere, yet.)

It's probably worth mentioning that the emacs 'linux' coding style is
pretty close to these guidelines - it's what I've been using (it might
differ on switch statements, but I can't get excited about precise matching
in that case).

There probably ought to be a note that '#if's should only exist in a very
small number of files.. cconfig.h, compopt.h and platform.h. Use of
editlevels.h #defines is wrong; if one is in doubt about a change, add a
unit test (checking that nothing else breaks) and be extra verbose in the
commit message.

Last aside - assert should be used more enthusiastically throughout..

Peter