Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all packages even only packages with sum type declared are passed as arguments? #4

Closed
eyasy1217 opened this issue Jan 6, 2024 · 2 comments

Comments

@eyasy1217
Copy link

Hi.

if the sum type is declared in one package and the type switch is in a different package, If only packages with sum type declared are passed as arguments to the A command, it doesn't reported missing cases.
Is it possible to check all packages even only packages with sum type declared are passed as arguments?
For example, by adding an option like --find-all-packages.🤔
In that case, the sum type defined in all packages would be undetected.

I am using this go-check-sumtype from golangci-lint and I am encountering the same problem as golangci/golangci-lint#4158 .
Should I fix golangci-lint or this standalone in the first place?🤔

@alecthomas
Copy link
Owner

Are you sure the standalone tool exhibits this behaviour? IIUC it is an issue with how it's integrated into golangci-lint.

@alecthomas
Copy link
Owner

I verified that the tool works correctly, so it needs to be fixed in the downstream golangci-lint integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants