Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - confirm before clean bookmark? #755

Open
iamqiz opened this issue Oct 19, 2024 · 5 comments
Open

[FEATURE] - confirm before clean bookmark? #755

iamqiz opened this issue Oct 19, 2024 · 5 comments

Comments

@iamqiz
Copy link

iamqiz commented Oct 19, 2024

when I click the clean button ,it clean all bookmarks Silently without warning

@alefragnani
Copy link
Owner

Hi @iamqiz ,

Do you mean the Clear button which is available for each file in the Side Bar?

image

I agree it is a good improvement, and I guess it could be added to the Clear from All Files command as well.

Hope this helps

@iamqiz
Copy link
Author

iamqiz commented Oct 28, 2024

@alefragnani

Do you mean the Clear button which is available for each file in the Side Bar?

yes

is this button is bound to command bookmarks.clear ?

by the way ,I find a issue : after run bookmarks: Clear or click clear button, if I right-click the line number that was bookmarked before, it still show "remove bookmark " instead of "add bookmark"

recording

@alefragnani
Copy link
Owner

Hi @iamqiz ,

About the Clear button, the confirmation should be added, as commented.

About the issue you did find with the context menu in the gutter, I just created #758 to fix it. It should be available in the next release.

Hope this helps

@iamqiz iamqiz closed this as completed Oct 29, 2024
@iamqiz
Copy link
Author

iamqiz commented Oct 29, 2024

@alefragnani thanks!

@alefragnani alefragnani reopened this Oct 29, 2024
@alefragnani
Copy link
Owner

I'll leave this issue open as well, to track the confirmation dialog feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants