Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin libbpfgo version #51

Open
maxgio92 opened this issue Dec 6, 2024 · 2 comments
Open

Pin libbpfgo version #51

maxgio92 opened this issue Dec 6, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@maxgio92
Copy link
Collaborator

maxgio92 commented Dec 6, 2024

Because libbpf is statically linked I think it would be beneficial for compatibility to pin the libbpfgo version.
Same applies for libbpfgo headers.

For instance, you could keep libbpfgo as submodule and bump it and test it as soon as a new release or even commit only is available.

@alegrey91
Copy link
Owner

I agree with you, we should pin the libbpf version in order to make harpoon more stable.

@alegrey91 alegrey91 added the good first issue Good for newcomers label Dec 10, 2024
@maxgio92
Copy link
Collaborator Author

IMO it is be as simple as adding it as submodule maxgio92/yet-another-profiler#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants