Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting to @now/static-build to support now-dev for the expo app #1

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

rlindskog
Copy link

@rlindskog rlindskog commented Jan 29, 2020

-DON'T MERGE-

  • adds a dev script to package.json with WEB_PORT=$PORT (WEB_PORT source) to forward the dev port from now dev ($PORT source)
  • update now.json to use @now/static-build which looks at the dev command locally, and build when deployed.
  • Properly proxy routes to the new output.
  • update readme, no longer need to start expo server separately

@vercel
Copy link

vercel bot commented Jan 29, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@alepacheco
Copy link
Owner

Thanks for the commit @rlindskog. Have you tested the changes?

@rlindskog
Copy link
Author

Thanks for the commit @rlindskog. Have you tested the changes?

No prob! On a similar repo, let me check on this to be sure.

@rlindskog
Copy link
Author

It looks like now-dev isn't working very well for this, might be the same problem as this issue. Might wanna hold off for a bit, not really sure what's going on but now-dev is having trouble proxying messages from /sockjs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants