Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac packages are a ZIP within a ZIP #2

Open
suy opened this issue Jan 12, 2022 · 0 comments
Open

Mac packages are a ZIP within a ZIP #2

suy opened this issue Jan 12, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@suy
Copy link

suy commented Jan 12, 2022

Hola Alex. 👋🏼 😃

Thank you for the template. It has helped me a lot on setting up my project, and I will probably need to look at it again for a Windows package.

I would like to mention that the ZIP packages coming straight from the Github workflows are a ZIP... which inside the run was content already in another ZIP. For example, if I go the latest run, the macOS.zip download is a ZIP package, which in turn contains the ZIP that was created via the workflow.

Seems there is no solution to this, but I'd like to point it out just in case you want to skip the zipping, to avoid confusion. Myself, I've went the way to upload the whole .app bundle, as the upload-artifact action can upload a directory just fine, but also to create a DMG with macdeployqt and publish that as well. DMGs used to be the way to get applications on Macs, at least some time ago, so I suppose that will be good.

For reference, here is what I've used in my case:

      - name: Deploy app
        run: |
          macdeployqt bin/MyApp.app
          macdeployqt bin/MyApp.app -dmg
          mv bin/MyApp.app MyApp-${{env.APP_VERSION}}.app
          mv bin/MyApp.dmg MyApp-${{env.APP_VERSION}}.dmg

      - name: Upload DMG
        uses: actions/upload-artifact@v2
        with:
          name: MyApp-${{env.APP_VERSION}}.dmg
          path: MyApp-${{env.APP_VERSION}}.dmg

      - name: Upload app bundle
        uses: actions/upload-artifact@v2
        with:
          name: MyApp-${{env.APP_VERSION}}.app
          path: MyApp-${{env.APP_VERSION}}.app

Cheers, and thank you again.

@suy suy added the bug Something isn't working label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant