Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interface names under title should reflect config.php #27

Open
brianjmurrell opened this issue Nov 5, 2018 · 4 comments
Open

interface names under title should reflect config.php #27

brianjmurrell opened this issue Nov 5, 2018 · 4 comments

Comments

@brianjmurrell
Copy link

If I define friendly names for interfaces in config.php, the page main title shows that name in brackets, but the interface names below -- the clickable links, still show the raw names. They should show the friendly names.

@alexandermarston
Copy link
Owner

Hi @brianjmurrell

Can you confirm that $use_predefined_interfaces is set to false?

Could you perhaps post your config.php?

Thanks.

@brianjmurrell
Copy link
Author

Can you confirm that $use_predefined_interfaces is set to false?

false? The comment says: // Set to true to set your own interfaces and the code says:

if ($use_predefined_interfaces == true) {
    $interface_list = ["eth0", "eth1", "tun0", "6to4", "sit0"];

    $interface_name['eth0'] = "Internet";
    $interface_name['eth1'] = "LAN";
    $interface_name['tun0'] = "VPN";
} else {
    $interface_list = getVnstatInterfaces($vnstat_bin_dir);

    foreach ($interface_list as $interface) {
        $interface_name[$interface] = $interface;
    }
}

So my $interface_name[*]s are only being used when $use_predefined_interfaces == true.

What am I misunderstanding?

@alexandermarston
Copy link
Owner

Ah, OK I understand what you mean - that's a fair point.

In your case would you rather the link say:

  • eth0 (Internet)
  • Internet
  • some other variant

@brianjmurrell
Copy link
Author

I think we agree. What I have currently is:

Network Traffic (Internet)
eth0, eth1, tun0, 6to4, sit0

It should be

Network Traffic (Internet)
Internet, LAN, VPN, 6to4, sit0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants