-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bidi support #324
Comments
Hi, you or someone else is free to send a PR. This theme was built around English and other Latin-based languages; anything beyond that is beyond my knowledge and not currently supported. |
Thanks for the response and it is understandable. I'll stress the changes for the text flow and check for edge cases that spawn from it in the meantime. On a sidenote and a bit far from now but is there a preferable way and interest to provide test cases of what is the expected result visually? If so what are they? |
The only thing is not to break other functionality. There are no test cases for such cases, only for code. |
Hi, would you consider implementing this in Flex 3.0? The changes are being done in |
Hello,
Sure, I'll give it a better look from my side
If it is not a problem do you have a pointer on how to generate the
minified CSS?
Last I've tried I had to change it in the minified version since the
mechanism was a bit more obscure which I guess won't work as a general
solution.
BR
…On Sat, 1 Apr 2023, 01:52 Alexandre Vicenzi, ***@***.***> wrote:
Hi, would you consider implementing this in Flex 3.0?
—
Reply to this email directly, view it on GitHub
<#324 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ5PCA7DHXDZP4S3TYOB7LW65NY7ANCNFSM6AAAAAAUJCM5SM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hi, v3 will remove Less and any other pre-processors, it will be plain CSS. |
Hello, Edit: |
Hello,
I was trying to use this theme but encountered an issue with post that contain both Hebrew and English
I was able to add the support by changing the css to include
I've added it just for headers and p since it wasn't obvious how the cascading was working, and it seems to localize the damage. the endresult seems good enough for my usecase but probably you would want to use it page wide and further testing(haven't done much with web ui)
Without it would look like
with it appears to be correct with the following final output
testing in MDN in their demo other values seems to get the general directionality but result in punctuation marks shifting to the start which is incorrect.
The text was updated successfully, but these errors were encountered: