Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bidi support #324

Open
Ds886 opened this issue Jan 27, 2023 · 8 comments
Open

Add bidi support #324

Ds886 opened this issue Jan 27, 2023 · 8 comments
Labels

Comments

@Ds886
Copy link

Ds886 commented Jan 27, 2023

Hello,
I was trying to use this theme but encountered an issue with post that contain both Hebrew and English

I was able to add the support by changing the css to include

unicode-bidi:plaintext
text-align:start

I've added it just for headers and p since it wasn't obvious how the cascading was working, and it seems to localize the damage. the endresult seems good enough for my usecase but probably you would want to use it page wide and further testing(haven't done much with web ui)

Without it would look like
image

with it appears to be correct with the following final output
image

testing in MDN in their demo other values seems to get the general directionality but result in punctuation marks shifting to the start which is incorrect.

@Ds886
Copy link
Author

Ds886 commented Jan 27, 2023

Now testing it does create some awkward overriding when needing to customize or around quotation so not sure if it is the best approach
image

> <center>נכתב פה עיר מלוכה ווינא</br>יום ה" כ"ז לחדש תשרי</br> שנת חמשת אלפים</br><span style="font-size: 1.5em">תרי"א</span></br>לבריאת</br>עולם</center>

also minor but is there a way to shift the quotation line to the right?
image

@alexandrevicenzi
Copy link
Owner

Hi, you or someone else is free to send a PR.

This theme was built around English and other Latin-based languages; anything beyond that is beyond my knowledge and not currently supported.

@Ds886
Copy link
Author

Ds886 commented Feb 5, 2023

Thanks for the response and it is understandable.

I'll stress the changes for the text flow and check for edge cases that spawn from it in the meantime.

On a sidenote and a bit far from now but is there a preferable way and interest to provide test cases of what is the expected result visually? If so what are they?

@alexandrevicenzi
Copy link
Owner

The only thing is not to break other functionality. There are no test cases for such cases, only for code.

@alexandrevicenzi alexandrevicenzi added this to the 3.0-dev milestone Mar 31, 2023
@alexandrevicenzi
Copy link
Owner

alexandrevicenzi commented Mar 31, 2023

Hi, would you consider implementing this in Flex 3.0?

The changes are being done in v3 branch, but it will take some time to be ready.

@alexandrevicenzi alexandrevicenzi removed this from the 3.0-dev milestone Mar 31, 2023
@Ds886
Copy link
Author

Ds886 commented Mar 31, 2023 via email

@alexandrevicenzi
Copy link
Owner

Hi,

v3 will remove Less and any other pre-processors, it will be plain CSS.
I will try to push the changes next week.

@Ds886
Copy link
Author

Ds886 commented Apr 8, 2023

Hello,
started messing with it a bit , Ill give it a few more tests.
Outside of list autogenerated in a non-overridable manner so the numbering stays LTR I was able to resolve most
It seems to generally work but ill give it more look, had some weird cache issue in firefox.

Edit:
I just checked on firefox whatever issue I've had seems to resolve itself I don't see any obvious issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants