Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodules not being released with tags #203

Open
pete-woods opened this issue Apr 8, 2024 · 1 comment
Open

Submodules not being released with tags #203

pete-woods opened this issue Apr 8, 2024 · 1 comment

Comments

@pete-woods
Copy link

Dependabot / renovate have trouble with the sub-modules in this module, seemingly because they are not released / tagged.

When you have submodules, usually it's easiest to follow some rules:

  • Have all submodules follow the same major version.
  • Tag all submodules for release at the same time as the main module:
    • e.g. v2.8.0 for the main module
    • and badgerstore/v2.8.0, boltstore/v2.8.0, bunstore/v2.8.0, etc for the sub modules.

See an example of how the tagging is supposed to be done here: https://github.com/hbjydev/go-submods-example/tags

At the moment, the store submodules all appear to be v1 modues, and also not tagged, so it really confuses any tools that want to automatically update them, as those tools want to pull down the latest v1 SCS, which is v1.4.1, and things go wrong.

I don't know what strategy you prefer to employ here, but would really appreciate something being figured out. Also as I'm using this library I'm willing to help out in any way I can.

@deltamualpha
Copy link

Yeah, I had to just pull the redisstore module directly into my codebase because when go's module resolution tried to work out how to use github.com/alexedwards/scs/redisstore it always ended up trying to load github.com/alexedwards/scs v1.4.1, the packages of which are not compatible with github.com/alexedwards/scs/v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants