Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all corresponding APIs with dynamic finality parameter #5

Open
alexfilatov opened this issue Dec 31, 2021 · 0 comments
Open

Update all corresponding APIs with dynamic finality parameter #5

alexfilatov opened this issue Dec 31, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alexfilatov
Copy link
Owner

WHY

Currently I implemented all APIs with finality: final, which would be used in the most use cases.
But this is not correctly reflects provided possibilities of the NEAR RPC as finality could be final or optimistic.

WHAT

Update all corresponding APIs with dynamic finality param and create tests for new options.
@alexfilatov alexfilatov added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexfilatov