Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crc16 kermit mask issue ? #52

Open
goestrip opened this issue Mar 16, 2018 · 2 comments
Open

crc16 kermit mask issue ? #52

goestrip opened this issue Mar 16, 2018 · 2 comments

Comments

@goestrip
Copy link

in the kermit crc computation, a 0xFFFF mask is used, but when checking with the C lib at
https://github.com/lammertb/libcrc/blob/master/src/crckrmit.c

in the same funciton, the mask used is 0x00FF

which one is correct ?

@rawr51919
Copy link

rawr51919 commented Mar 28, 2019

The latter seems to be more correct in this case, since we are dealing with CRC16 hashes here. 0xFFFF only makes sense when CRC32 hashes are being dealt with. It seems that this library is actually correct with it's hashing, now that I'm scrutinizing it.

@rawr51919
Copy link

@alexgorbatchev, you can go ahead and close this issue as there never was an issue to talk about here in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants