Remaining temp files

[HolyGit12]

crf-search does not delete all temp files after finishing the search.
The both files of the last sample are staying in the temp folder. The temp folder won't be removed.
(Windows version but I guess that this does not matter)

[9Oc]

I am also experiencing this after the newest version [0.9.1] with the sample-encode command as well.

[alexheretic]

It's possible a recent ffmpeg process is still alive and prevents cleanup. I recently removed logic that would, a little too eagerly, kill ffmpeg so this makes sense.

So I'll look at adding graceful shutdown of these child processes which should resolve this.

[alexheretic]

I've implemented awaiting for child processes, like ffmpeg, to exit before temp file cleanup. Hopefully this should resolve this issue, though I couldn't actually reproduce it myself.

If possible can you let me know if this resolves the issue, you can install the latest code via cargo.

[mr44er]

Windows version but I guess that this does not matter

Maybe so. Windows Explorer starts generating thumbnails from videos and this means that a process hangs on the files that prevents them from being deleted. I just don't know how long the timeout is.
https://www.windowscentral.com/how-disable-thumbnails-windows-10