Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extends with plugins doesn't work #18

Open
axten opened this issue Dec 9, 2018 · 8 comments
Open

extends with plugins doesn't work #18

axten opened this issue Dec 9, 2018 · 8 comments

Comments

@axten
Copy link

axten commented Dec 9, 2018

...so for now, removing this in favor of stylelint-find-new-rules

@alexilyaev
Copy link
Owner

@axten Is this related to #9 specifically or something else is broken?

@axten
Copy link
Author

axten commented Dec 9, 2018

I don't know...
What I can say is that is was broken with version 0.8
0.7 was working fine.

I just link to an order.js with rules, like this

    extends: [
        './rules/order',
    ],

@alexilyaev
Copy link
Owner

@axten Can you please elaborate on your full use case?
What did you expect the results to be?

in v0.8.0 I've added support for extends:

How does it handle extends?

The rules of extends are added to the list of configured rules, thus, if a rule is covered in an extend config, it will not show up in the unused results.

So unless ./rules/order has an extends of it's own, this should work.
And by "work" I mean it should not show rules defined in the extends as being unused.

@alexilyaev
Copy link
Owner

alexilyaev commented Dec 11, 2018

@axten I've put in some work and now in v2.0.0 it fully supports extends of extends:
https://github.com/alexilyaev/stylelint-find-rules/releases/tag/v2.0.0

Would you mind giving it a try and letting me know if it works for you?

@axten
Copy link
Author

axten commented Dec 12, 2018

cool, it's not broken anymore!
UNUSED looks good

but INVALID is wrong:

INVALID: Configured rules that are no longer available:

RULE
order/order
order/properties-order

so 'stylelint-order' plugin is not considered correctly.

@alexilyaev
Copy link
Owner

alexilyaev commented Dec 14, 2018 via email

@axten
Copy link
Author

axten commented Dec 14, 2018

maybe https://github.com/Donov4n/stylelint-find-new-rules can give you a hint...
maybe its time to join forces

@alexilyaev
Copy link
Owner

Yeah, mentioned it at Donov4n/stylelint-find-new-rules#2

And will check it as part of #20

@alexilyaev alexilyaev changed the title extends support is broken extends with plugins doesn't work Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants