-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Koa support #1
Comments
Agree, it would be awesome. Although I don't have much experience with Koa. Do you know what is lacking to make them work together? Thanks. |
Hi Alex :) I am also not familiar with Koa. I'm just responding to Github issue requests and passing it forward. |
Hi Joe. How are things? :) I just noticed that issue is from 2016 :) |
I'd like to add koa support to this but it looks like the repo isn't really maintained anymore. If this is the case would you be okay with the agenda org taking this project over? |
Hey, thanks for your interest. I'm still using the library in few of my projects. |
Is there any documentation on how to add a new adapter and/or a recommended way to do it? |
This folder will expose you to the world of pain :) Probably most straightforward way to approach it, would be to print out koa's Request / Response object (properties and methods) and see how it aligns with the existing API. Most likely you'd need to change existing API and make it all async functions, so it would support both models. Then there is a question of that other servers – how they work with async functions/promises instead of callbacks. Seems like it'd be breaking change and most likely would require to drop support for old versions, in order to fully embrace the brave new world of async functions. Good luck, thank you. And let me know if you hit a roadblock or there are questions. |
It'd be great if we can get Koa support in here per agenda/agendash#30 and agenda/agendash#45 (comment) cc @joeframbach
The text was updated successfully, but these errors were encountered: