Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert plugin to a federated plugin and remove Android APIs #97

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Convert plugin to a federated plugin and remove Android APIs #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0648b7e
(#61) add writeToFile, writeToFileAsBytes, writeToFileAsString
jfaltis Jul 14, 2022
83fa900
(#85) Apply PR fixes
alexrintt Jul 15, 2022
90ae52d
(#85, #79, #61) Add more actions related to the `writeToFile` API
alexrintt Jul 15, 2022
605dab4
(#56, #39) Remove `MediaStore` and `Environment` APIs
alexrintt Jul 15, 2022
6859263
(#56, #39) Update documentation of `MediaStore` and `Environment` API
alexrintt Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions android/src/main/kotlin/io/lakscastro/sharedstorage/SharedStoragePlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,14 @@ import io.flutter.embedding.engine.plugins.FlutterPlugin
import io.flutter.embedding.engine.plugins.FlutterPlugin.FlutterPluginBinding
import io.flutter.embedding.engine.plugins.activity.ActivityAware
import io.flutter.embedding.engine.plugins.activity.ActivityPluginBinding
import io.lakscastro.sharedstorage.environment.EnvironmentApi
import io.lakscastro.sharedstorage.mediastore.MediaStoreApi
import io.lakscastro.sharedstorage.storageaccessframework.StorageAccessFrameworkApi
import io.lakscastro.sharedstorage.plugin.SharedStorageApi

const val ROOT_CHANNEL = "io.lakscastro.plugins/sharedstorage"

/** Flutter plugin Kotlin implementation `SharedStoragePlugin` */
class SharedStoragePlugin : FlutterPlugin, ActivityAware {
/** `Environment` API channel */
private val environmentApi = EnvironmentApi(this)

/** `MediaStore` API channel */
private val mediaStoreApi = MediaStoreApi(this)

/** `DocumentFile` API channel */
private val storageAccessFrameworkApi = StorageAccessFrameworkApi(this)
private val sharedStorageApi = SharedStorageApi(this)

lateinit var context: Context
var binding: ActivityPluginBinding? = null
Expand All @@ -30,25 +22,21 @@ class SharedStoragePlugin : FlutterPlugin, ActivityAware {
override fun onAttachedToEngine(@NonNull flutterPluginBinding: FlutterPluginBinding) {
context = flutterPluginBinding.applicationContext

environmentApi.startListening(flutterPluginBinding.binaryMessenger)
mediaStoreApi.startListening(flutterPluginBinding.binaryMessenger)
storageAccessFrameworkApi.startListening(flutterPluginBinding.binaryMessenger)
sharedStorageApi.startListening(flutterPluginBinding.binaryMessenger)
}

override fun onAttachedToActivity(binding: ActivityPluginBinding) {
this.binding = binding

storageAccessFrameworkApi.startListeningToActivity()
sharedStorageApi.startListeningToActivity()
}

override fun onDetachedFromEngine(@NonNull binding: FlutterPluginBinding) {
environmentApi.stopListening()
mediaStoreApi.stopListening()
storageAccessFrameworkApi.stopListening()
sharedStorageApi.stopListening()
}

override fun onDetachedFromActivityForConfigChanges() {
storageAccessFrameworkApi.stopListeningToActivity()
sharedStorageApi.stopListeningToActivity()
}

override fun onReattachedToActivityForConfigChanges(binding: ActivityPluginBinding) {
Expand Down
2 changes: 1 addition & 1 deletion .../sharedstorage/plugin/ActivityListener.kt → .../sharedstorage/common/ActivityListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.lakscastro.sharedstorage.plugin
package io.lakscastro.sharedstorage.common

/**
* Interface shared across API classes to make intuitive and clean [init] and [dispose] plugin
Expand Down
2 changes: 1 addition & 1 deletion ...lakscastro/sharedstorage/plugin/Common.kt → ...lakscastro/sharedstorage/common/Common.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.lakscastro.sharedstorage.plugin
package io.lakscastro.sharedstorage.common

import android.os.Build
import io.flutter.plugin.common.MethodChannel
Expand Down
2 changes: 1 addition & 1 deletion ...castro/sharedstorage/plugin/Listenable.kt → ...castro/sharedstorage/common/Listenable.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.lakscastro.sharedstorage.plugin
package io.lakscastro.sharedstorage.common

import io.flutter.plugin.common.BinaryMessenger

Expand Down
2 changes: 1 addition & 1 deletion ...ro/sharedstorage/plugin/PluginConstant.kt → ...ro/sharedstorage/common/PluginConstant.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.lakscastro.sharedstorage.plugin
package io.lakscastro.sharedstorage.common

import android.os.Build

Expand Down
100 changes: 0 additions & 100 deletions android/src/main/kotlin/io/lakscastro/sharedstorage/environment/EnvironmentApi.kt
View file
Open in desktop

This file was deleted.

70 changes: 0 additions & 70 deletions android/src/main/kotlin/io/lakscastro/sharedstorage/mediastore/MediaStoreApi.kt
View file
Open in desktop

This file was deleted.

Loading