From 590ef74ce259a3f21ebbb4a053d2f60c832536d0 Mon Sep 17 00:00:00 2001 From: Alexey Antonov Date: Thu, 2 Jan 2025 15:30:33 +0200 Subject: [PATCH] fix: [Security:Rules:Detection Rules:Create Rule] Time input interval spinner for timeperiod input to suppress alerts is missing form label Closes: #204498 --- .../components/suppression_duration_selector.tsx | 1 + .../rule_creation/components/duration_input/index.tsx | 3 +++ 2 files changed, 4 insertions(+) diff --git a/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_creation/components/alert_suppression_edit/components/suppression_duration_selector.tsx b/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_creation/components/alert_suppression_edit/components/suppression_duration_selector.tsx index 7cf5eeb3018b1..b3a5c8308453c 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_creation/components/alert_suppression_edit/components/suppression_duration_selector.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_creation/components/alert_suppression_edit/components/suppression_duration_selector.tsx @@ -132,6 +132,7 @@ const SuppressionDurationSelectorFields = memo(function SuppressionDurationSelec disabled || suppressionDurationSelectorField.value !== AlertSuppressionDurationType.PerTimePeriod } + aria-label={i18n.ALERT_SUPPRESSION_DURATION_PER_TIME_PERIOD_OPTION} minimumValue={1} /> diff --git a/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_creation/components/duration_input/index.tsx b/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_creation/components/duration_input/index.tsx index b203cdea8f737..0b35bc1f82564 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_creation/components/duration_input/index.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_creation/components/duration_input/index.tsx @@ -18,6 +18,7 @@ interface DurationInputProps { minimumValue?: number; isDisabled: boolean; durationUnitOptions?: Array<{ value: 's' | 'm' | 'h' | 'd'; text: string }>; + 'aria-label'?: string; } // This component is similar to the ScheduleItem component, but instead of combining the value @@ -33,6 +34,7 @@ export const DurationInput = memo(function DurationInputComponent({ { value: 'm', text: I18n.MINUTES }, { value: 'h', text: I18n.HOURS }, ], + 'aria-label': ariaLabel, ...props }: DurationInputProps): JSX.Element { const { euiTheme } = useEuiTheme(); @@ -98,6 +100,7 @@ export const DurationInput = memo(function DurationInputComponent({ onChange={onChangeTimeVal} value={durationValue} data-test-subj="interval" + aria-label={ariaLabel} {...rest} />