Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for different networks, node templates #12

Closed
wants to merge 3 commits into from
Closed

Support for different networks, node templates #12

wants to merge 3 commits into from

Conversation

stefandevo
Copy link
Contributor

This PR contains support for :

This allows you to set your ip range and subnet for private network:
#2

variable "ip_range" {
    type = string
    default = "172.16.0.0/12"
    description = "Ip Range to use for setting up Hetzner network."
}

variable "subnet_ip_range" {
    type = string
    default = "172.16.1.0/24"
    description = "Subnet Ip Range to use for setting up Hetzner network."
}

Extra parameters for the node-init:
Solving #10

variable "use_private_networks" {
  type = bool
  default = false
  description = "Use private network in node templates."
}

variable "node_cloud_init_path" {
    type = string
    default = ""
    description = "Path to the cloud init user data for node templates."
}

variable "node_template_types" {
    type = list(string)
    default = ["cx", "cx-ceph", "cpx", "ccx"]
    description = "All server types for which a node template will be created"
}

variable "node_template_zones" {
    type = list(string)
    default = ["nbg1", "fsn1", "hel1"]
    description = "All zones for which a node template will be created."
}

The node init will create by default ALL possible nodes, but with the above variables you can choose from zones and type combination.

Please note that #11 private network checkbox is not working.

@stefandevo
Copy link
Contributor Author

I see that this PR also includes the changes from #6

@stefandevo
Copy link
Contributor Author

stefandevo commented Jan 30, 2021

Extra note ... beside the error of the Private Network that is not working for the node template, I see that the Docker Install URL is pointing to 18.09sh.
When I tried to install my cluster, the docker was failing.
When I changed that to the latest 19.03.sh my cluster was provisioning.

Also (maybe related) Ubuntu 16 was created instead of the pointed 20.
When I changed a created template, changed the combo box to 20, used that template, I got:
Error setting machine configuration from flags provided: --hetzner-image and --hetzner-image-id

So I guess the node template part is not stable.

@alexzimmer96 alexzimmer96 added bug Something isn't working enhancement New feature or request labels Feb 1, 2021
@alexzimmer96 alexzimmer96 self-assigned this Feb 1, 2021
@alexzimmer96 alexzimmer96 linked an issue Feb 1, 2021 that may be closed by this pull request
@alexzimmer96 alexzimmer96 removed the bug Something isn't working label Feb 1, 2021
@alexzimmer96
Copy link
Owner

alexzimmer96 commented Feb 2, 2021

Looks like #6 established conflicts. Can you resolve them and squash your commits?

@alexzimmer96 alexzimmer96 linked an issue Feb 2, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make NodeTemplate creation configurable Introduce variable for private network cidr
2 participants