Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffering #817

Open
SebastianStehle opened this issue Jul 23, 2022 · 1 comment
Open

Buffering #817

SebastianStehle opened this issue Jul 23, 2022 · 1 comment

Comments

@SebastianStehle
Copy link

  • Algolia Client Version: #.#.#
  • Language Version:

Description

I have seen that you use a lot of buffering (aka MemoryStream) for request and response parsing. It has some value for retries, but for the successful cases it causes unnecessary pressure on the GC.

Is this something you would accept a PR?

Steps To Reproduce
@Ant-hem
Copy link
Member

Ant-hem commented Jul 26, 2022

Hello,

Can you elaborate on your use case?
Would you also have some numbers/benchmarks to share regarding the GC/memory pressure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SebastianStehle @Ant-hem